Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NH-94685: capture stacktrace for span #288

Merged
merged 2 commits into from
Dec 26, 2024
Merged

NH-94685: capture stacktrace for span #288

merged 2 commits into from
Dec 26, 2024

Conversation

cleverchuk
Copy link
Contributor

@cleverchuk cleverchuk commented Dec 12, 2024

Integrate the io.opentelemetry.contrib:opentelemetry-span-stacktrace package for collecting stack trace base on span duration and some configured span attributes used filters. The default duration is 5ms and the default filter attribute is db.system.

Users can add additional span attributes by configuring -Dsw.apm.span.stacktrace.filters with comma separated list of span attributes to use in the filter. The filter does an existence test for any of the configured attribute. The filter and the duration together select the spans whose stack trace are collected.

Test Plan:
Test services data 0, 1, 2 and 3

@cleverchuk cleverchuk requested a review from a team as a code owner December 12, 2024 20:17
cheempz
cheempz previously approved these changes Dec 19, 2024
Copy link
Contributor

@cheempz cheempz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @cleverchuk! Left some comments and questions.

@cleverchuk
Copy link
Contributor Author

Build will fail because we need to merge this first

Copy link
Contributor

@cheempz cheempz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the revisit @cleverchuk! You mentioned our SpanStacktraceFilter could additionally match on span name which seems like a good idea for follow-on (maybe once we adopt the file-based config ;)

@cleverchuk cleverchuk merged commit 48e95c9 into main Dec 26, 2024
13 checks passed
@cleverchuk cleverchuk deleted the cc/NH-94685 branch December 26, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants